updateImage: Don't assign DisplayName if it doesn't exist #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves issue plotly#283
|
Still getting: |
|
Still getting the same output as the issue example (just as @VolKa79). |
xarico10
suggested changes
Aug 5, 2021
There was a problem hiding this comment.
";" not needed after an if statement (line 95). Also, that conditional is pointless.
if ~isempty(image_data.DisplayName)
obj.data{imageIndex}.name = image_data.DisplayName;
else
obj.data{imageIndex}.name = image_data.DisplayName;
The exact same command (obj.data{imageIndex}.name = image_data.DisplayName;) is being executed whether image_data.DisplayName is empty or not.
|
Looking at the changes, it seems like the current master already resolved this issue, isn't it? |
|
I can see that this commit is no longer necessary since this was resolved in master here 59481e8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves issue #283